fix: adds accessibile labels to moderation buttons#2065
fix: adds accessibile labels to moderation buttons#2065thisislawatts wants to merge 4 commits intomasterfrom
Conversation
Use new `showIconOnly` property and use margin-left for consistent layout.
thisislawatts
force-pushed
the
fix/moderation-how-to-buttons
branch
18 times, most recently
from
dd44630 to
bf8e0c7
Compare
commitlint@17.4.0 appears to break in CI pipeline: https://app.circleci.com/pipelines/github/ONEARMY/community-platform/3579/workflows/a0cef11b-74d5-48ef-adba-a29db3a29f04/jobs/22860
thisislawatts
force-pushed
the
fix/moderation-how-to-buttons
branch
from
bf8e0c7 to
950e9be
Compare
chrismclarke
left a comment
chrismclarke
left a comment
There was a problem hiding this comment.
One minor comment from me but otherwise happy with the code. I'll leave it to @davehakkens if there's any related design issues
.circleci/config.yml
Outdated
| npm config set package-lock false | ||
| npm i @types/node @commitlint/types @commitlint/config-conventional --force | ||
| npx commitlint --from=$(git merge-base remotes/origin/${CIRCLE_BRANCH} master) --verbose | ||
| npm ls |
There was a problem hiding this comment.
nit(non-blocking)
Do we still need this line?
chrismclarke
left a comment
chrismclarke
left a comment
There was a problem hiding this comment.
@thisislawatts
I tried to manually remove the additional npm-ls call however when running locally it seems like the commitlint config is not working
PS C:\apps\oneArmy\community-platform> git commit -m "chore: remove ci npm ls"
⧗ input: chore: remove ci npm ls
✖ Please add rules to your `commitlint.config.js`
- Getting started guide: https://git.io/fhHij
- Example config: https://git.io/fhHip [empty-rules]
✖ found 1 problems, 0 warnings
ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
Would you be able to either try fixing (I'm guessing something to do with the version installed or difference with commitlint vs @commitlint/cli), or moving the config changes into a separate PR so that we can still merge the labels update?
|
On second thoughts I could probably try be a bit more useful (!) There seems to be a side-issue with commitlint now not happier with the description length on some of the earlier commits so I'll also try move that to #2071 to fix |
|
🎉 This issue has been resolved in version 1.35.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
4 participants
PR Checklist
PR Type
Description
Use new
showIconOnlyproperty and use margin-leftfor consistent layout.
Screenshots/Videos
Before:
After: